Add Puppet 8 compatibility #178

tuxmea · 2024-02-16T10:15:38Z

update gems to use voxpupuli test gem
lint auto fix
update puppet version im metadata.json

- update gems to use voxpupuli test gem - lint auto fix - update puppet version im metadata.json

td-adc · 2024-03-27T22:58:06Z

@derdanne Any chance you could take a look at this?

bschonec · 2024-05-20T12:45:36Z

@derdanne I have several updates awaiting this pull request. Would you be so kind as to merge it?

bschonec · 2024-05-20T12:59:04Z

@tuxmea , I'm getting the following errors when running 'bundle install'. Would you test against your puppet8 branch to see if you're getting the same error before I put too much effort into figuring out why?

Could not find compatible versions

Because voxpupuli-test < 2.5.0 depends on puppetlabs_spec_helper >= 2.14.0
  and voxpupuli-test >= 2.5.0, < 4.0.0 depends on puppetlabs_spec_helper >= 2.16.0,
  voxpupuli-test < 4.0.0 requires puppetlabs_spec_helper >= 2.14.0.
And because voxpupuli-test >= 5.5.0, < 6.0.0 depends on puppetlabs_spec_helper >= 5.0.3
  and voxpupuli-test >= 4.0.0, < 5.5.0 depends on puppetlabs_spec_helper >= 4.0.0,
  voxpupuli-test < 6.0.0 requires puppetlabs_spec_helper >= 2.14.0.
Because rspec-puppet >= 2.0, < 3.A could not be found in https://github.com/puppetlabs/rspec-puppet.git (at main@6fd7094)
  and puppetlabs_spec_helper >= 1.2.1, < 6.0.0.rc.1 depends on rspec-puppet ~> 2.0,
  puppetlabs_spec_helper >= 1.2.1, < 6.0.0.rc.1 cannot be used.
Thus, voxpupuli-test < 6.0.0 requires puppetlabs_spec_helper >= 6.0.0.rc.1.
And because voxpupuli-test >= 7.1.0 depends on puppetlabs_spec_helper >= 7.0.1, < 8.A
  and puppetlabs_spec_helper >= 7.1.0, < 7.2.0 depends on puppet-syntax ~> 4.1,
  either puppet-syntax ~> 4.1 or puppetlabs_spec_helper >= 6.0.0.rc.1, < 7.1.0 OR >= 7.2.0.
And because puppetlabs_spec_helper >= 7.0.4, < 7.1.0 depends on puppet-syntax ~> 4.0
  and puppetlabs_spec_helper >= 5.0.0, < 7.0.4 depends on puppet-syntax ~> 3.0,
  either puppet-syntax ~> 3.0 OR >= 4.0, < 5.A or puppetlabs_spec_helper >= 7.2.0.
And because puppet-syntax >= 2.6.1, < 4.0.0 depends on puppet >= 5
  and puppetlabs_spec_helper >= 7.2.0 depends on puppet-syntax >= 4.1.1, < 5.A,
  either puppet >= 5 or puppet-syntax >= 4.0.0, < 5.A.
So, because puppet-syntax >= 4.0.0 depends on puppet >= 7, < 9
  and Gemfile depends on puppet ~> 4.0,
  version solving has failed.

bschonec · 2024-05-22T11:20:12Z

@tuxmea I can confirm that your latest updates fix my "bundle install" problem.

bschonec · 2024-05-31T14:30:25Z

Now that this project is under the Voxpupuli project, can we get this merged in so that the tests are fixed? I have things I'd like to contribute, too.

yakatz · 2024-05-31T14:47:53Z

I approved the tests to run

yakatz · 2024-05-31T14:53:31Z

The test setup needs to be updated to use the newer Ruby and Puppet versions: .github/workflows/test-suite.yaml

tuxmea · 2024-06-07T10:07:44Z

Tests are still failing. I am unsure, why. Can we get this merged, so we have Puppet 8 support? rspec tests show no errors.

TheMeier · 2024-06-07T10:47:16Z

Hm I think we should not simply ignore that:

  Error: /Stage[main]/Nfs::Server::Service/Service[nfs-kernel-server]/ensure: change from 'stopped' to 'running' failed: Systemd start for nfs-kernel-server failed!

tuxmea · 2024-06-07T12:31:47Z

I am not able to reproduce the Ubuntu 20 error on a vagrant box.
Code:

# Vagrantfile
Vagrant.configure("2") do |config|
  config.vm.box = "ubuntu/focal64"
end

# install puppet
wget https://apt.puppet.com/puppet8-release-focal.deb
sudo dpkg -i puppet8-release-focal.deb
sudo apt-get update
apt install -y puppet-agent

/opt/puppetlabs/puppet/bin/puppet module install puppetlabs-stdlib
/opt/puppetlabs/puppet/bin/puppet module install puppetlabs/concat
/opt/puppetlabs/puppet/bin/puppet module install puppetlabs/transition
/opt/puppetlabs/puppet/bin/puppet module install puppet/augeasproviders_core
/opt/puppetlabs/puppet/bin/puppet module install puppet/augeasproviders_shellvar
/opt/puppetlabs/puppet/bin/puppet module install puppetlabs/augeas_core
/opt/puppetlabs/puppet/bin/puppet module install puppetlabs/mount_core

ln -s /vagrant /etc/puppetlabs/code/environments/production/modules/nfs

# nfs.pp
        file { ['/export', '/data_folder', '/homeexport']:
          ensure => 'directory',
        }
        class { '::nfs':
          server_enabled => true,
          nfs_v4 => true,
          nfs_v4_idmap_domain => 'example.org',
          nfs_v4_export_root  => '/export',
          nfs_v4_export_root_clients => '*(rw,fsid=0,insecure,no_subtree_check,async,no_root_squash)',
        }
        nfs::server::export { '/data_folder':
          ensure  => 'mounted',
          clients => '*(rw,insecure,async,no_root_squash,no_subtree_check)',
          before => Class['nfs::server::service'],
        }
        nfs::server::export { '/homeexport':
          ensure  => 'mounted',
          clients => '*(rw,insecure,async,root_squash,no_subtree_check)',
          mount   => '/srv/home',
          before => Class['nfs::server::service'],
        }

h-haaks · 2024-06-07T13:08:57Z

In a Debian 10 container:

root@debian10-64-1:/# systemctl status nfs-server
● nfs-server.service - NFS server and services
   Loaded: loaded (/lib/systemd/system/nfs-server.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Fri 2024-06-07 13:03:26 UTC; 1min 8s ago
  Process: 2691 ExecStartPre=/usr/sbin/exportfs -r (code=exited, status=1/FAILURE)
  Process: 2692 ExecStopPost=/usr/sbin/exportfs -au (code=exited, status=0/SUCCESS)
  Process: 2693 ExecStopPost=/usr/sbin/exportfs -f (code=exited, status=0/SUCCESS)

Jun 07 13:03:26 debian10-64-1 systemd[1]: Starting NFS server and services...
Jun 07 13:03:26 debian10-64-1 exportfs[2691]: exportfs: /export does not support NFS export
Jun 07 13:03:26 debian10-64-1 systemd[1]: nfs-server.service: Control process exited, code=exited, status=1/FAILURE
Jun 07 13:03:26 debian10-64-1 systemd[1]: nfs-server.service: Failed with result 'exit-code'.
Jun 07 13:03:26 debian10-64-1 systemd[1]: Stopped NFS server and services.
root@debian10-64-1:/#

h-haaks · 2024-06-07T14:03:51Z

from https://hub.docker.com/r/kvaps/nfs-server

Requirements

The Docker host kernel will need the following kernel modules
    nfs
    nfsd
    rpcsec_gss_krb5 (only if Kerberos is used)

Usually you can enable these modules with: modprobe {nfs,nfsd,rpcsec_gss_krb5}

The container will need to run with CAP_SYS_ADMIN (or --privileged). This is necessary as the server needs to mount several filesystems inside the container to support its operation, and performing mounts from inside a container is impossible without these capabilities.

I guess this is a bit hard to satisfy on the github runners?

h-haaks · 2024-06-07T16:25:43Z

Some additional testing from me using beaker-docker on a rocky8 host.

rocky8 and 9 OK
debian12 OK
debian10 and 11 Fail
ubuntu2204 OK
ubuntu2004 Fail

containers can not start the servcie due to missing kernel modules

bastelfreak · 2024-06-09T20:12:49Z

.rspec

@@ -0,0 +1,5 @@
+# Managed by modulesync - DO NOT EDIT


please delete the file, modulesync doesn't deploy them anymore.

bastelfreak · 2024-06-09T20:12:55Z

.rspec_parallel

@@ -0,0 +1,4 @@
+# Managed by modulesync - DO NOT EDIT


please delete the file, modulesync doesn't deploy them anymore.

bastelfreak · 2024-06-09T20:14:33Z

README.md

@@ -1,11 +1,20 @@
 # nfs

+[![Build Status](https://github.com/voxpupuli/puppet-nfs/workflows/CI/badge.svg)](https://github.com/voxpupuli/puppet-nfs/actions?query=workflow%3ACI)


can you pull the README.md cleanup into it's own PR? It's not really related to the puppet 8 implementation

bastelfreak · 2024-06-09T20:22:40Z

manifests/client/config.pp

-    if $::nfs::defaults_file != undef {
-      if $::nfs::client_gssd_options != '' {
-        $_gssd1_aug = ["set ${::nfs::client_gssdopt_name} \"'${::nfs::client_gssd_options}'\""]
+  if $nfs::client::nfs_v4 {


I'm also a bit torn with all those linting changes, they are really not related to implementing Puppet 8 support, but rather pleasing puppet-lint. Can you maybe provide one PR with the result of bundle exec rake lint_fix?

h-haaks · 2024-06-09T22:00:37Z

To me there is just to many unrelated changes in this PR
I think it would be a good thing to focus on the transition into vox pupuli (as separate PRs) before adding new enhancements.

Puppet 8 compatibility

ba0b5e0

- update gems to use voxpupuli test gem - lint auto fix - update puppet version im metadata.json

bschonec mentioned this pull request May 20, 2024

Use edge-filepath module to create parent directories for NFS exports. #148

Open

use Gemfile from voxpupuli

589677c

tuxmea added 20 commits June 3, 2024 12:30

Update github workflows (based on puppet-gitlab)

a111ad3

Ad dmore test files from puppet-gitlab

8bca4a8

lint fixes

de188b8

lint updates

2a66dc4

MD fixes

160f6e5

refactor spec tests

4c1733a

update REFERENCE

ff1f4b9

use on_supported_os instead of self assigen os names

875241b

rubocop

99eee5b

revert new os tests to allow merge of puppet 8

f892695

enable puppet 8 tests

22e46d0

Merge remote-tracking branch 'voxpupuli/master' into puppet8

a929f74

rebase after modulesync

35fa0a6

remove ruby-lsp artefact

e1fd394

rubocop cleanup

c821684

remove outdated os add migrastion note, add badges

2aa5800

remove old test suite

e03dec5

no need to install modules on your own

3a75a20

add missing configure_beaker

6b6cd7e

rubocop

e4c6eac

tuxmea added 3 commits June 7, 2024 13:15

add missing directories to acceptance test

ba2e4f8

typo in dir name

e79827c

nfs::server::export needs strict dependenc to nfs::server:servcie class

f830987

tuxmea added 3 commits June 8, 2024 15:10

adopt acceptance test to local tests

137bfc9

disable serverspec tests for services

e8c8f95

containers can not start the servcie due to missing kernel modules

rubocop

8592a2f

tuxmea requested review from bastelfreak, rwaffen, TheMeier and h-haaks June 9, 2024 17:41

bastelfreak reviewed Jun 9, 2024

View reviewed changes

remove unneeded files

9a7607c

Merge branch 'master' into puppet8

013b898

bastelfreak approved these changes Jun 10, 2024

View reviewed changes

bastelfreak changed the title ~~Puppet 8 compatibility~~ Add Puppet 8 compatibility Jun 10, 2024

tuxmea merged commit 8409ddf into voxpupuli:master Jun 10, 2024
12 checks passed

tuxmea deleted the puppet8 branch June 10, 2024 08:53

bastelfreak added skip-changelog enhancement and removed skip-changelog labels Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Puppet 8 compatibility #178

Add Puppet 8 compatibility #178

tuxmea commented Feb 16, 2024

td-adc commented Mar 27, 2024

bschonec commented May 20, 2024

bschonec commented May 20, 2024

bschonec commented May 22, 2024

bschonec commented May 31, 2024

yakatz commented May 31, 2024

yakatz commented May 31, 2024

tuxmea commented Jun 7, 2024

TheMeier commented Jun 7, 2024

tuxmea commented Jun 7, 2024

h-haaks commented Jun 7, 2024

h-haaks commented Jun 7, 2024

h-haaks commented Jun 7, 2024

bastelfreak Jun 9, 2024

bastelfreak Jun 9, 2024

bastelfreak Jun 9, 2024

bastelfreak Jun 9, 2024

h-haaks commented Jun 9, 2024

		@@ -1,11 +1,20 @@
		# nfs

		[![Build Status](https://github.com/voxpupuli/puppet-nfs/workflows/CI/badge.svg)](https://github.com/voxpupuli/puppet-nfs/actions?query=workflow%3ACI)

Add Puppet 8 compatibility #178

Add Puppet 8 compatibility #178

Conversation

tuxmea commented Feb 16, 2024

td-adc commented Mar 27, 2024

bschonec commented May 20, 2024

bschonec commented May 20, 2024

bschonec commented May 22, 2024

bschonec commented May 31, 2024

yakatz commented May 31, 2024

yakatz commented May 31, 2024

tuxmea commented Jun 7, 2024

TheMeier commented Jun 7, 2024

tuxmea commented Jun 7, 2024

h-haaks commented Jun 7, 2024

h-haaks commented Jun 7, 2024

h-haaks commented Jun 7, 2024

bastelfreak Jun 9, 2024

Choose a reason for hiding this comment

bastelfreak Jun 9, 2024

Choose a reason for hiding this comment

bastelfreak Jun 9, 2024

Choose a reason for hiding this comment

bastelfreak Jun 9, 2024

Choose a reason for hiding this comment

h-haaks commented Jun 9, 2024